Fix a retain cycle in PostgreSQLConnection #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By adding a handler that retains self on the channel's close future, the connection gets retained until the channel is closed. We break the retain cycle by using a weak reference to self. The completion handler in `send(:onResponse:)` is enough to ensure that the connection stays alive while a message is sent to the server.
|
Changing base branch to |
tanner0101
reviewed
Feb 16, 2019
There was a problem hiding this comment.
I think this is a good change, but I also think that we should be verifying (at least in debug builds) that close() is called before a connection deinits.
Something like this:
final class PostgresConnection {
deinit {
assert(self.isClosed, "PostgresConnection.close() not called before deinit")
}
}That way we can ensure code is properly cleaning up resources allocated by the connection.
|
Currently the connection automatically closes in |
|
@baarde ah yeah, you are right. This LGTM. 👍 |
|
Hey @baarde, you just merged a pull request, have a coin! You now have 7 coins. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By adding a handler that retains self on the channel's close future, the connection gets retained until the channel is closed. We break the retain cycle by using a weak reference to self. The completion handler in
send(:onResponse:)is enough to ensure that the connection stays alive while a message is sent to the server.